Login Tools - Errors in userlog.csv

[evi]

Version 18.4.0 sometime generates defect csv-lines:
DEFECT:
2023-10-31,11:27:22,77.33.34.146,Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36 Edg/118.0.2088.69,/OT67/forum.php,ev67,SUCCESS
Contains 8 fields

CORRECT:
2023-10-31,18:11:57,77.170.230.130,Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/118.0,ev-soft.dk/OT67/login.php,eh67,SUCCESS
Contains 7 fields

From php-file:
fwrite($log_file, implode(',', [$log_date, $log_time, $log_ip_address, $log_user_agent, $log_referrer, $db_username, 'SUCCESS'])."\r\n");

It looks like comma in "(KHTML, like Gecko)" is triggering a extra field !!!

[Pablo]

Note that this has nothing to do with the version 18.4.0.
The information comes directly from the browser. It is not a 'defect' in WWB. The data will be inserted "AS IS".
So, it looks like it was a change in the data provided by the browser.

I will investigate if the comma can be removed from the data before adding it to csv.

[evi]

Maybe: str_replace(',','¤',$log_user_agent) ?

[Pablo]

I will take a look at this.

[evi]

Change in login.php near line 38:
From original:

Code: Select all

fwrite($log_file, implode(',', [$log_date, $log_time, $log_ip_address, $log_user_agent, $log_referrer, $_POST['username'], 'FAILED'])."\r\n");

do replace ',' to 'SPACE' in $log_user_agent
To patched:

Code: Select all

 fwrite($log_file, implode(',', [$log_date, $log_time, $log_ip_address, str_replace(',',' ',$log_user_agent), $log_referrer, $_POST['username'], 'FAILED'])."\r\n");

Now that version 19 is released, does that mean there will be no more updates to version 18?

[Pablo]

There will still be updates for Wb18 but no new features will be added, only fixes.