jor_magnificManipulation 1.0

In this section you can share self-made extensions with other users of WYSIWYG Web Builder.

There are already more than 250 extensions available!
User avatar
rogerl
 
 
Posts: 155
Joined: Tue May 03, 2016 8:24 am

Re: jor_magnificManipulation 1.0

Post by rogerl » Mon Jun 11, 2018 10:36 am

OK will have ago tomorrow, not feeling the best, having early night.

User avatar
rogerl
 
 
Posts: 155
Joined: Tue May 03, 2016 8:24 am

Re: jor_magnificManipulation 1.0

Post by rogerl » Tue Jun 12, 2018 2:39 am

OK we're on a roll!
Screenshots, landscape and portrait from Chrome on Android (Samsung J7 Pro):
Image

Image

I have removed my stuff and reinstated the global height of 700 as requested.
https://www.whiteshepherdsnz.com/NewSit ... ppies.html
I've uploaded my test project file "fancy.wbs" file to Sendspace - The page in discussion is "mwsPuppies":
https://www.sendspace.com/file/eq3d11

jordan
 
 
Posts: 829
Joined: Tue Jun 26, 2007 1:56 pm
Contact:

Re: jor_magnificManipulation 1.0

Post by jordan » Tue Jun 12, 2018 11:36 am

rogerl wrote:
Tue Jun 12, 2018 2:39 am
OK we're on a roll!
Screenshots, landscape and portrait from Chrome on Android (Samsung J7 Pro):
Image

Image

I have removed my stuff and reinstated the global height of 700 as requested.
https://www.whiteshepherdsnz.com/NewSit ... ppies.html
I've uploaded my test project file "fancy.wbs" file to Sendspace - The page in discussion is "mwsPuppies":
https://www.sendspace.com/file/eq3d11
your on a role indeed:)goOd, but ...

1.
you have set your online demo formatting to minify
thereby I can not easily see what is happening on your page - (de-minify please)

2.
second your fancy.wbs is made in WB14? - I have WB14, but not installed, so I can not open it:\

3.
third your screen captures do tell a story that I partly can see myself
in portrait I can see somewhat the same occurring on your site, not in landscape tho

probable solution:
your site is 1250px in page width !
reduce your site page width to max. 980px - (preferable smaller)
re-order content to fit that space

does that fix the problem ?

User avatar
rogerl
 
 
Posts: 155
Joined: Tue May 03, 2016 8:24 am

Re: jor_magnificManipulation 1.0

Post by rogerl » Tue Jun 12, 2018 12:08 pm

you have set your online demo formatting to minify
thereby I can not easily see what is happening on your page - (de-minify please)
Now that you mention this I noticed this minify thing the other day. Appears to have been introduced when I switched to V14 but no idea where the setting is. Any ideas?
On some of my pages I decided not to do break points as no full background images, Perhaps I'll do that conversion and see what happens.
Thanks for your patience.

jordan
 
 
Posts: 829
Joined: Tue Jun 26, 2007 1:56 pm
Contact:

Re: jor_magnificManipulation 1.0

Post by jordan » Tue Jun 12, 2018 12:29 pm

rogerl wrote:
Tue Jun 12, 2018 12:08 pm
Now that you mention this I noticed this minify thing the other day. Appears to have been introduced when I switched to V14 but no idea where the setting is. Any ideas?
On some of my pages I decided not to do break points as no full background images, Perhaps I'll do that conversion and see what happens.
Thanks for your patience.
minify is:
Tools > Options > HTML > formatting

just try it on a separate small project with max. width 980px and jor_magnificManipulation
no hurries 8)

User avatar
rogerl
 
 
Posts: 155
Joined: Tue May 03, 2016 8:24 am

Re: jor_magnificManipulation 1.0

Post by rogerl » Tue Jun 12, 2018 12:41 pm

Thanks, just found the setting when your notification came through. Have changed setting and uploaded Beautify edition to that same link I gave you.

jordan
 
 
Posts: 829
Joined: Tue Jun 26, 2007 1:56 pm
Contact:

Re: jor_magnificManipulation 1.0

Post by jordan » Tue Jun 12, 2018 1:05 pm

thank you, but still not optimal for me, the javascript and css is still minified
Tools > Options > HTML > Css > formatting
Tools > Options > HTML > Javascript > formatting

but at the moment it is not important
first try to reduce the page width to see if that solves your problem anyway:)

User avatar
rogerl
 
 
Posts: 155
Joined: Tue May 03, 2016 8:24 am

Re: jor_magnificManipulation 1.0

Post by rogerl » Tue Jun 12, 2018 9:40 pm

fixed and uploaded

jordan
 
 
Posts: 829
Joined: Tue Jun 26, 2007 1:56 pm
Contact:

Re: jor_magnificManipulation 1.0

Post by jordan » Wed Jun 13, 2018 10:19 am

rogerl wrote:
Tue Jun 12, 2018 9:40 pm
fixed and uploaded
nice, - now change your page width to see if it solves the problem ?

User avatar
rogerl
 
 
Posts: 155
Joined: Tue May 03, 2016 8:24 am

Re: jor_magnificManipulation 1.0

Post by rogerl » Fri Jun 15, 2018 12:46 pm

HI Jordan,
Reduced page width 980px
in your extension have global max-width 850 and global max height 700.
Checked on mobiles browsers Chrome and Firefox same problem as before.
Mobile browsers are a pain. Apart from the fixed position issue which I have a suggested fix, maybe the remaining problem has to be addressed in media queries to cope with width and height within portrait and landscape situations?

jordan
 
 
Posts: 829
Joined: Tue Jun 26, 2007 1:56 pm
Contact:

Re: jor_magnificManipulation 1.0

Post by jordan » Fri Jun 15, 2018 3:07 pm

rogerl wrote:
Fri Jun 15, 2018 12:46 pm
HI Jordan,
Reduced page width 980px
in your extension have global max-width 850 and global max height 700.
Checked on mobiles browsers Chrome and Firefox same problem as before.
Mobile browsers are a pain. Apart from the fixed position issue which I have a suggested fix, maybe the remaining problem has to be addressed in media queries to cope with width and height within portrait and landscape situations?
I have tried to replicate your problem, I can not
here is my demo -CORRECT WORKING DEMO - it just works correct for me !!? - same setting as you!
something on your site must be conflicting, creating this behaviour
all I can say is reduce your site to a bare minimum as my demo displays, first see if that works correct
then start adding until you find what's causing it
:idea:

jordan
 
 
Posts: 829
Joined: Tue Jun 26, 2007 1:56 pm
Contact:

Re: jor_magnificManipulation 1.0

Post by jordan » Fri Jun 15, 2018 7:24 pm

hi rogerl,

duh, - now I finally see the problem ... you have a viewport meta tag - but your site is not RWD?
did you add the mete tag manual?
- remove the meta tag, that should solve the problem!

User avatar
rogerl
 
 
Posts: 155
Joined: Tue May 03, 2016 8:24 am

Re: jor_magnificManipulation 1.0

Post by rogerl » Fri Jun 15, 2018 9:45 pm

Good morning,
OK, that solved the fixed issue:
Image

Image

but landscape still has issues, or is it that magnific tries to stay within the viewport rather than the page?
This is one of those moments when a decision comes back to haunt you as I remember Pablo highlighting at one time that if you weren't using bps then take that meta tag out and then Web Builder would put it back in automatically if bps were used. Given the number of pages I have on the main site I left the issue for later and forgot it Now I've done bps for most pages I might have to add it back on the list.

jordan
 
 
Posts: 829
Joined: Tue Jun 26, 2007 1:56 pm
Contact:

Re: jor_magnificManipulation 1.0

Post by jordan » Sat Jun 16, 2018 1:24 pm

rogerl wrote:
Fri Jun 15, 2018 9:45 pm
Good morning,
OK, that solved the fixed issue:
Image

Image

but landscape still has issues, or is it that magnific tries to stay within the viewport rather than the page?
This is one of those moments when a decision comes back to haunt you as I remember Pablo highlighting at one time that if you weren't using bps then take that meta tag out and then Web Builder would put it back in automatically if bps were used. Given the number of pages I have on the main site I left the issue for later and forgot it Now I've done bps for most pages I might have to add it back on the list.
if you have a viewport tag AND your site is RWD then it won't be a problem, then the content fits the bp

anyway, I created an update that should fix the problem
for mobile devices it pushes the magnific lightbox back into position
DOWNLOAD jor_magnificManipulation1.1
I do not have time to test it thorough, please test for yourself, feedback is welcome;)
I will release it official later if I got some time to test ...

hope this will help - cheeriO!

User avatar
rogerl
 
 
Posts: 155
Joined: Tue May 03, 2016 8:24 am

Re: jor_magnificManipulation 1.0

Post by rogerl » Mon Jun 18, 2018 8:12 am

Thanks Jordon. Will spend a bit more time on it shortly and probably look at making those pages have bps. Seems like everything is hitting the fan this week so have to re-prioritise my projects.
Regards
Roger

Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests